D21113: Allow hiding option items depending on available extension and version in the host
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri May 10 08:46:07 BST 2019
broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
We already have somewhat of a versioning system available in the host and it stores and exposes information about what extension it supports and in what version.
This makes this information available to the options page and allows hiding elements using the `data-requires-extension="foo"` and `data-requires-extension-version-minimum="2"` attributes.
This is for better compatibility when adding new features to the host which is released independently of the extension.
Since the settings are still read and the items still added to the DOM, saving settings will not touch/change the enabled state of unsupported extensions should you use the extension on multiple computers with different versions of the host.
TEST PLAN
Depends on D21112 <https://phabricator.kde.org/D21112>
- Added a new item with required extension attribute, didn't add it to the host, had the item successfully hidden
- Added a new item with a required version of 2, had the item successfully hidden
- Verified that saving would still write the enabled state correctly
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D21113
AFFECTED FILES
extension/extension.js
extension/options.css
extension/options.js
To: broulik, #plasma, fvogt
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190510/77256e52/attachment.html>
More information about the Plasma-devel
mailing list