D21422: [Notifications] Fix translations in popup
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon May 27 08:16:00 BST 2019
broulik created this revision.
broulik added reviewers: Plasma, aacid, yurchor.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
The popup is a pure QML singleton and as such doesn't inherit the i18n context from the applet. Use `i18nd` explicitly.
BUG: 407927
TEST PLAN
- Stuff in popup is translated properly now
`main.qml` and `FullRepresentation.qml` aren't changed as they are items that are used in the applet like normal.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D21422
AFFECTED FILES
applets/notifications/package/contents/ui/EditContextMenu.qml
applets/notifications/package/contents/ui/JobDetails.qml
applets/notifications/package/contents/ui/JobItem.qml
applets/notifications/package/contents/ui/NotificationHeader.qml
applets/notifications/package/contents/ui/NotificationItem.qml
applets/notifications/package/contents/ui/ThumbnailStrip.qml
To: broulik, #plasma, aacid, yurchor
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190527/a7b4821e/attachment.html>
More information about the Plasma-devel
mailing list