<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, aacid, yurchor.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21422">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The popup is a pure QML singleton and as such doesn't inherit the i18n context from the applet. Use <tt style="background: #ebebeb; font-size: 13px;">i18nd</tt> explicitly.</p>

<p>BUG: 407927</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Stuff in popup is translated properly now</li>
</ul>

<p><tt style="background: #ebebeb; font-size: 13px;">main.qml</tt> and <tt style="background: #ebebeb; font-size: 13px;">FullRepresentation.qml</tt> aren't changed as they are items that are used in the applet like normal.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21422">https://phabricator.kde.org/D21422</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>applets/notifications/package/contents/ui/EditContextMenu.qml<br />
applets/notifications/package/contents/ui/JobDetails.qml<br />
applets/notifications/package/contents/ui/JobItem.qml<br />
applets/notifications/package/contents/ui/NotificationHeader.qml<br />
applets/notifications/package/contents/ui/NotificationItem.qml<br />
applets/notifications/package/contents/ui/ThumbnailStrip.qml</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, aacid, yurchor<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>