D21134: [Notifications] Tweak paddings

[Kai Uwe Broulik]

broulik added a comment.


  Not a huge fan of the dialog margins tbh. The additional row spacing inside looks fine.
  
  Especially the top padding looks a bit off, same for the right padding to the icon.
  F6818773: Screenshot_20190511_094009.png <https://phabricator.kde.org/F6818773>
  The padding of the screenshot doesn't match the rest of the notification now
  F6818770: Screenshot_20190511_094220.png <https://phabricator.kde.org/F6818770>
  The right padding doesn't match anymore either
  F6818775: Screenshot_20190511_094424.png <https://phabricator.kde.org/F6818775>
  It also breaks when no buttons are in the title bar (that wasn't ideal before but now is even more noticeable), can be triggered when starting a copy progress and unchecking "keep progress open" in settings
  F6818778: Screenshot_20190511_094550.png <https://phabricator.kde.org/F6818778>
  
  Code is fine I guess.

INLINE COMMENTS

> NotificationItem.qml:263
>          Layout.fillWidth: true
> +        Layout.leftMargin: units.smallSpacing
> +        Layout.rightMargin: units.smallSpacing

Why is this not `bodyLeftPadding`?

> NotificationItem.qml:265
> +        Layout.rightMargin: units.smallSpacing
> +        Layout.bottomMargin: units.smallSpacing
>          active: notificationItem.notificationType === NotificationManager.Notifications.JobType

Can't you just increase the overall `spacing` of the `ColumnLayout` rather than setting this `bottomMargin` all over the place?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21134

To: ngraham, #vdg, broulik
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190511/4ea5b645/attachment.html>