<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21134">View Revision</a></tr></table><br /><div><div><p>Not a huge fan of the dialog margins tbh. The additional row spacing inside looks fine.</p>
<p>Especially the top padding looks a bit off, same for the right padding to the icon.<br />
<a href="https://phabricator.kde.org/F6818773" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6818773: Screenshot_20190511_094009.png</a><br />
The padding of the screenshot doesn't match the rest of the notification now<br />
<a href="https://phabricator.kde.org/F6818770" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6818770: Screenshot_20190511_094220.png</a><br />
The right padding doesn't match anymore either<br />
<a href="https://phabricator.kde.org/F6818775" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6818775: Screenshot_20190511_094424.png</a><br />
It also breaks when no buttons are in the title bar (that wasn't ideal before but now is even more noticeable), can be triggered when starting a copy progress and unchecking "keep progress open" in settings<br />
<a href="https://phabricator.kde.org/F6818778" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6818778: Screenshot_20190511_094550.png</a></p>
<p>Code is fine I guess.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21134#inline-118668">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationItem.qml:263</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">Layout.fillWidth:</span> <span style="color: #000a65">true</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.leftMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.rightMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Why is this not <tt style="background: #ebebeb; font-size: 13px;">bodyLeftPadding</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21134#inline-118667">View Inline</a><span style="color: #4b4d51; font-weight: bold;">NotificationItem.qml:265</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.rightMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.bottomMargin:</span> <span style="color: #004012">units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">active:</span> <span style="color: #004012">notificationItem</span><span class="p">.</span><span style="color: #004012">notificationType</span> <span style="color: #aa2211">===</span> <span style="color: #004012">NotificationManager</span><span class="p">.</span><span style="color: #004012">Notifications</span><span class="p">.</span><span style="color: #004012">JobType</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can't you just increase the overall <tt style="background: #ebebeb; font-size: 13px;">spacing</tt> of the <tt style="background: #ebebeb; font-size: 13px;">ColumnLayout</tt> rather than setting this <tt style="background: #ebebeb; font-size: 13px;">bottomMargin</tt> all over the place?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21134">https://phabricator.kde.org/D21134</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, broulik<br /><strong>Cc: </strong>apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>