D21027: [Notes] Fix icons being almost invisible with light backgrounds

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:63
> +    // an unknown colour over a known colour is a bad move as you end up with white on yellow.
> +    function textIconColor() {
> +        if (plasmoid.configuration.color === "black" || plasmoid.configuration.color === "translucent-light") {

Make that

  readonly property color textIconColor: {
      if (plasmoid....) {
          ...
      }
      ...
  }

> main.qml:258
>  
> -                PlasmaComponents.ToolButton {
> -                    tooltip: i18nc("@info:tooltip", "Bold")
> -                    iconSource: "format-text-bold"
> +                QQC2.ToolButton {
> +                    icon.name: "format-text-bold"

Not too happy of using desktop buttons here instead of plasma components but custom color stuff doesn't work in Plasma.
However, given it's a tool button and this solves a genuine usability problem I think this is fine.

Can you make the button follow the size of a normal Plasma `ToolButton` or the `units.iconSizes` or something at least? They are a bit tiny here because they rely on Qt scaling which Plasma doesn't do

REPOSITORY
  R114 Plasma Addons

BRANCH
  background-appropriate-icon-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21027

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190509/5d20bf41/attachment-0001.html>