D20797: [dict] Modernize configuration window

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConfigDictionaries.qml:55
>  
>              delegate: Item {
> +                width: root.width

Control {

which should have the highlight rectangle as background:

and the Label as contentItem:

this will give it some nice paddings, as now it looks quite cramped

> ConfigDictionaries.qml:63
>                      visible: model.id == root.cfg_dictionary
>                      color: syspal.highlight
>                  }

Kirigami.Theme.highlightColor

> ConfigDictionaries.qml:67
> +                /*Text { text: model.id }*/
> +                Text {
> +                    id: pathText

Label {

> ConfigDictionaries.qml:71
> +                    text: model.description
> +                    color: model.id == root.cfg_dictionary ? syspal.highlightedText : syspal.text
>                  }

Kirigami.Theme.textColor

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20797

To: filipf, dfaure, ngraham, #vdg, #plasma, davidedmundson, mart
Cc: mart, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190509/1d6e28b1/attachment.html>