<table><tr><td style="">mart requested changes to this revision.<br />mart added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20797">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20797#inline-118536">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigDictionaries.qml:55</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">delegate:</span> <span style="color: #004012">Item</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">width:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">paren</span>t</span><span class="p">.</span><span style="color: #004012">width</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">width:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">roo</span>t</span><span class="p">.</span><span style="color: #004012">width</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Control {</p>
<p style="padding: 0; margin: 8px;">which should have the highlight rectangle as background:</p>
<p style="padding: 0; margin: 8px;">and the Label as contentItem:</p>
<p style="padding: 0; margin: 8px;">this will give it some nice paddings, as now it looks quite cramped</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20797#inline-118533">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigDictionaries.qml:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">visible:</span> <span style="color: #004012">model</span><span class="p">.</span><span style="color: #004012">id</span> <span style="color: #aa2211">==</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">cfg_dictionary</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">color:</span> <span style="color: #004012">syspal</span><span class="p">.</span><span style="color: #004012">highlight</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Kirigami.Theme.highlightColor</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20797#inline-118535">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigDictionaries.qml:67</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">/*Text { text: model.id }*/</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">Text</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">id: pathText</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Label {</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20797#inline-118534">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigDictionaries.qml:71</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">text:</span> <span style="color: #004012">model</span><span class="p">.</span><span style="color: #004012">description</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">color:</span> <span style="color: #004012">model</span><span class="p">.</span><span style="color: #004012">id</span> <span style="color: #aa2211">==</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">cfg_dictionary</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">syspal.highlightedText :</span> <span style="color: #004012">syspal</span><span class="p">.</span><span style="color: #004012">text</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Kirigami.Theme.textColor</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20797">https://phabricator.kde.org/D20797</a></div></div><br /><div><strong>To: </strong>filipf, dfaure, ngraham, VDG, Plasma, davidedmundson, mart<br /><strong>Cc: </strong>mart, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>