D20930: Update WireGuard to match NetworkManager 1.16 interface

Bruce Anderson noreply at phabricator.kde.org
Thu May 9 02:14:07 BST 2019


andersonbruce added a comment.


  In D20930#462547 <https://phabricator.kde.org/D20930#462547>, @ngraham wrote:
  
  > So much better!
  >
  > I have one more little suggestion for the buttons: move the "Remove Peer" button into the bottom of the tab for that peer to make it clear what it applies to, and change the text to say, "Remove this Peer". The Remove button can stay where it is, but maybe should say, "Add New Peer". Actually, is "Add" the correct verb? Would "Connect to" be more appropriate?
  
  
  Here is a proposed version of what you asked for.  It also contains a little more context showing the parent dialog where the rest of the configuration is entered, behind the Peers dialog under discussion.
  
  Personally I like the Add and Remove buttons to be together where they were, and to simply change the wording to "Add New Peer" and "Remove This Peer". I think this still makes it clear that the peer in the tab currently being displayed in the dialog is the one that will be removed but am willing to do it the way shown below if the VDG considers it to be more consistent with the rest of KDE.
  
  The wording should definitely not be "Connect to" because this form is used to edit a configuration not to actually make a connection. Hitting "Connect" on a WireGuard configuration activates all the peers in that configuration at one time. I haven't set up a large multi-user server but I imagine one could contain dozens if not hundreds of peers.
  F6815862: RemoveBtnMoved.png <https://phabricator.kde.org/F6815862>

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D20930

To: andersonbruce, jgrulich, #vdg
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190509/6a6e2041/attachment.html>


More information about the Plasma-devel mailing list