D20265: Introduce libnotificationmanager

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> notificationgroupcollapsingproxymodel.cpp:175
> +    emit dataChanged(idx, idx, dirtyRoles);
> +    emit dataChanged(idx.child(0, 0), idx.child(rowCount(idx) - 1, 0), dirtyRoles);
> +

I know this really sucks, and I'm not going to be pushy on this because you've been waiting on this review forever.

But: Qt 5.13 has deprecated `QModelIndex::child` (they want us to use `QAIM::index` now always), leading to noisy builds. For new code it'd be amazing to avoid it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20265

To: broulik, #plasma
Cc: hein, mart, nicolasfella, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190505/9971341b/attachment.html>