D21029: UpdatesPage: Don't try to translate version numbers

[Pino Toscano]

pino added a comment.


  The explanation of this change does not match the code changes: the code never translated the version numbers, but it composed a string showing the version numbers before and after the upgrade.
  Could it simply be that one of the two (for example `installedVersion`) is null?

INLINE COMMENTS

> UpdatesPage.qml:239
>                              elide: Text.ElideRight
> -                            text: i18n("%1 → %2", installedVersion, availableVersion)
> +                            text: "%1 → %2".arg(installedVersion).arg(availableVersion)
>                              visible: !truncated

I do not think this change is correct: "%1 → %2" is a UI string, and thus it must be translatable.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21029

To: jbbgameich, #discover_software_store
Cc: pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190505/eaae67bf/attachment-0001.html>