<table><tr><td style="">pino added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21029">View Revision</a></tr></table><br /><div><div><p>The explanation of this change does not match the code changes: the code never translated the version numbers, but it composed a string showing the version numbers before and after the upgrade.<br />
Could it simply be that one of the two (for example <tt style="background: #ebebeb; font-size: 13px;">installedVersion</tt>) is null?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21029#inline-118024">View Inline</a><span style="color: #4b4d51; font-weight: bold;">UpdatesPage.qml:239</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                            <span style="color: #aa4000">elide:</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">ElideRight</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                            <span style="color: #aa4000">text:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #766510">"%1 → %2"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #004012">installedVersion<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #004012">availableVersion</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                            <span style="color: #aa4000">text:</span> <span style="color: #766510">"%1 → %2"<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">arg</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #004012">installedVersion<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">).</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">arg</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span style="color: #004012">availableVersion</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                            <span style="color: #aa4000">visible:</span> <span style="color: #aa2211">!</span><span style="color: #004012">truncated</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I do not think this change is correct: "%1 → %2" is a UI string, and thus it must be translatable.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21029">https://phabricator.kde.org/D21029</a></div></div><br /><div><strong>To: </strong>jbbgameich, Discover Software Store<br /><strong>Cc: </strong>pino, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>