D20969: [potd] Modernize configuration settings

[Nathaniel Graham]

ngraham added a comment.


  Nice job. But I shudder to think of how long this string must be in German or Brazilian Portuguese:
  F6806865: Screenshot_20190503_123158.png <https://phabricator.kde.org/F6806865>

INLINE COMMENTS

> config.qml:76
> +        implicitWidth: Math.max(providerTextMetrics.width + Kirigami.Units.gridUnit * 2 + Kirigami.Units.smallSpacing * 2, pluginComboBox.width) //QQC1 Combobox default sizing is broken
> +        Kirigami.FormData.label: i18ndc("plasma_wallpaper_org.kde.potd", "@label:listbox", "Providers:")
> +        model: providerModel

This should not be plural and should probably say "Provider:" or maybe even "Source:".

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D20969

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190503/fac63673/attachment.html>