<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20969">View Revision</a></tr></table><br /><div><div><p>Nice job. But I shudder to think of how long this string must be in German or Brazilian Portuguese:<br />
<a href="https://phabricator.kde.org/F6806865" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6806865: Screenshot_20190503_123158.png</a></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D20969#inline-117870">View Inline</a><span style="color: #4b4d51; font-weight: bold;">config.qml:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">implicitWidth:</span> <span style="color: #304a96">Math</span><span class="p">.</span><span style="color: #004012">max</span><span class="p">(</span><span style="color: #004012">providerTextMetrics</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">+</span> <span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">Units</span><span class="p">.</span><span style="color: #004012">gridUnit</span> <span style="color: #aa2211">*</span> <span style="color: #601200">2</span> <span style="color: #aa2211">+</span> <span style="color: #004012">Kirigami</span><span class="p">.</span><span style="color: #004012">Units</span><span class="p">.</span><span style="color: #004012">smallSpacing</span> <span style="color: #aa2211">*</span> <span style="color: #601200">2</span><span class="p">,</span> <span style="color: #004012">pluginComboBox</span><span class="p">.</span><span style="color: #004012">width</span><span class="p">)</span> <span style="color: #74777d">//QQC1 Combobox default sizing is broken</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">Kirigami.FormData.label:</span> <span style="color: #004012">i18ndc</span><span class="p">(</span><span style="color: #766510">"plasma_wallpaper_org.kde.potd"</span><span class="p">,</span> <span style="color: #766510">"@label:listbox"</span><span class="p">,</span> <span style="color: #766510">"Providers:"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">model:</span> <span style="color: #004012">providerModel</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This should not be plural and should probably say "Provider:" or maybe even "Source:".</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R114 Plasma Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20969">https://phabricator.kde.org/D20969</a></div></div><br /><div><strong>To: </strong>filipf, Plasma, VDG, ngraham<br /><strong>Cc: </strong>abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart<br /></div>