D19825: Improve update states' UI

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Mar 17 16:57:31 GMT 2019


apol added a comment.


  conceptual +1

INLINE COMMENTS

> UpdatesPage.qml:152
> +                Layout.maximumHeight: Layout.minimumHeight
> +                visible: isBusy
> +            }

use `page.isBusy` so it doesn't have to start looking for the symbol all over the place

> UpdatesPage.qml:318
>              name: "fetching"
> -            PropertyChanges { target: page; title: i18nc("@info", "Fetching...") }
> -            PropertyChanges { target: page; footerLabel: i18nc("@info", "Checking for updates...") }
> +            PropertyChanges { target: page; footerLabel: i18nc("@info", "Gathering updates...") }
> +            PropertyChanges { target: page; isBusy: true }

Gathering reads super weird to me.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19825

To: ngraham, apol, #vdg, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190317/8fcdb924/attachment-0001.html>


More information about the Plasma-devel mailing list