<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19825">View Revision</a></tr></table><br /><div><div><p>conceptual +1</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19825#inline-111319">View Inline</a><span style="color: #4b4d51; font-weight: bold;">UpdatesPage.qml:152</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.maximumHeight:</span> <span style="color: #004012">Layout</span><span class="p">.</span><span style="color: #004012">minimumHeight</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">visible:</span> <span style="color: #004012">isBusy</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">use <tt style="background: #ebebeb; font-size: 13px;">page.isBusy</tt> so it doesn't have to start looking for the symbol all over the place</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19825#inline-111320">View Inline</a><span style="color: #4b4d51; font-weight: bold;">UpdatesPage.qml:318</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">name:</span> <span style="color: #766510">"fetching"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">PropertyChanges</span> <span class="p">{</span> <span style="color: #aa4000">target:</span> <span style="color: #004012">page</span><span class="p">;</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">title</span>:</span> <span style="color: #004012">i18nc</span><span class="p">(</span><span style="color: #766510">"@info"</span><span class="p">,</span> <span style="color: #766510">"<span class="bright">Fetching</span>..."</span><span class="p">)</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #004012">PropertyChanges</span> <span class="p">{</span> <span style="color: #aa4000">target:</span> <span style="color: #004012">page</span><span class="p">;</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">footerLabel:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">i18nc</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"@info"</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">"Checking for updates..."</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">PropertyChanges</span> <span class="p">{</span> <span style="color: #aa4000">target:</span> <span style="color: #004012">page</span><span class="p">;</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">footerLabel</span>:</span> <span style="color: #004012">i18nc</span><span class="p">(</span><span style="color: #766510">"@info"</span><span class="p">,</span> <span style="color: #766510">"<span class="bright">Gathering updates</span>..."</span><span class="p">)</span> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">PropertyChanges</span> <span class="p">{</span> <span style="color: #aa4000">target:</span> <span style="color: #004012">page</span><span class="p">;</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">isBusy:</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">true</span></span> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Gathering reads super weird to me.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R134 Discover Software Store</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19825">https://phabricator.kde.org/D19825</a></div></div><br /><div><strong>To: </strong>ngraham, apol, VDG, Discover Software Store<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>