D22135: pack drkonqi into a transient static lib we can use for unit testing

[Aleix Pol Gonzalez]

apol added a comment.


  +1 for the spirit of the patch, I see you use the library in the other patches.

INLINE COMMENTS

> CMakeLists.txt:85
> +# transient static lib we can use to link autotests against
> +add_library(libdrkonqi STATIC ${drkonqi_SRCS})
>  

As a name it's a bit weird, the file will be called liblibdrkonqi.a.
How about calling it DrKonqiInternal?

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22135

To: sitter, #plasma
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190628/87004aec/attachment.html>