D22137: test SystemInformation class

Harald Sitter noreply at phabricator.kde.org
Fri Jun 28 13:05:23 BST 2019


sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  - has a new Config struct, encapsulates data we need to mangle for testing
  - new completeness state to make sure lsb_release has returned by the time we read data in the test
  - os-release fixture
  - lsb_release double
  
  the os-release test has expected failure right now because the current
  parser is in fact broken. needs porting to KOsRelease

TEST PLAN
  builds && passes

REPOSITORY
  R871 DrKonqi

BRANCH
  test-systeminfo

REVISION DETAIL
  https://phabricator.kde.org/D22137

AFFECTED FILES
  src/systeminformation.cpp
  src/systeminformation.h
  src/tests/CMakeLists.txt
  src/tests/data/os-release
  src/tests/lsb_release_double.c
  src/tests/systeminformationtest.cpp

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190628/2c79e5cf/attachment.html>


More information about the Plasma-devel mailing list