D20867: Add Property to disable drawing of menu arrow indicators

[David Hallas]

hallas added a comment.


  Hi @ngraham - I have looked into this patch set and it is a little tedious to test, you have to do the following:
  
  1. Apply the following patch to KWidgetAddons F6773036 <https://phabricator.kde.org/F6773036> then build and install it
  2. Apply this patch to breeze then build and install it
  3. Apply D19311 <https://phabricator.kde.org/D19311> to Dolphin
  4. Then make the following changes to Dolphin:
  
    diff --git a/CMakeLists.txt b/CMakeLists.txt
    index ef0e28e76..a86256950 100644
    --- a/CMakeLists.txt
    +++ b/CMakeLists.txt
    @@ -65,6 +65,7 @@ find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS
         Notifications
         Crash
         WindowSystem
    +    WidgetsAddons
     )
     find_package(KF5 ${KF5_MIN_VERSION} OPTIONAL_COMPONENTS
         Activities
    diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
    index 8a025e584..80a767aa9 100644
    --- a/src/CMakeLists.txt
    +++ b/src/CMakeLists.txt
    @@ -148,6 +148,7 @@ target_link_libraries(
         KF5::ConfigCore
         KF5::NewStuff
         KF5::Parts
    +    KF5::WidgetsAddons
         KF5::WindowSystem
     )
     
    diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
    index 1f1c1cea6..80db0bbe9 100644
    --- a/src/dolphinmainwindow.cpp
    +++ b/src/dolphinmainwindow.cpp
    @@ -1292,6 +1292,7 @@ void DolphinMainWindow::setupActions()
         }
         m_backAction->setDelayed(true);
         m_backAction->setStickyMenu(false);
    +    m_backAction->setMenuIndicator(false);
         connect(m_backAction, &QAction::triggered, this, &DolphinMainWindow::goBack);
         connect(m_backAction->menu(), &QMenu::aboutToShow, this, &DolphinMainWindow::slotAboutToShowBackPopupMenu);
         connect(m_backAction->menu(), &QMenu::triggered, this, &DolphinMainWindow::slotGoBack);
    @@ -1327,6 +1328,7 @@ void DolphinMainWindow::setupActions()
         }
         m_forwardAction->setDelayed(true);
         m_forwardAction->setStickyMenu(false);
    +    m_forwardAction->setMenuIndicator(false);
         connect(m_forwardAction, &QAction::triggered, this, &DolphinMainWindow::goForward);
         connect(m_forwardAction->menu(), &QMenu::aboutToShow, this, &DolphinMainWindow::slotAboutToShowForwardPopupMenu);
         connect(m_forwardAction->menu(), &QMenu::triggered, this, &DolphinMainWindow::slotGoForward);
  
  then build and install Dolphin, and then (phew) you should be able to see that the arrows are gone :D
  
  I have also rebased this patch.
  
  But if we agree to how this feature is implemented, I would suggest that we get this patch merged, then merge the patch for KWidgetAddons, and then when those two has been released, we merge the patch for Dolphin.
  
  What do you think?
  
  Here is a screenshot of how it looks with everything applied:
  
  F6935857: navigation_history_no_arrows.png <https://phabricator.kde.org/F6935857>

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D20867

To: hallas, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190626/0f6ca72d/attachment-0001.html>