<table><tr><td style="">hallas added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20867">View Revision</a></tr></table><br /><div><div><p>Hi <a href="https://phabricator.kde.org/p/ngraham/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ngraham</a> - I have looked into this patch set and it is a little tedious to test, you have to do the following:</p>

<ol class="remarkup-list">
<li class="remarkup-list-item">Apply the following patch to KWidgetAddons <a href="https://phabricator.kde.org/F6773036" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6773036</a> then build and install it</li>
<li class="remarkup-list-item">Apply this patch to breeze then build and install it</li>
<li class="remarkup-list-item">Apply <a href="https://phabricator.kde.org/D19311" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D19311</a> to Dolphin</li>
<li class="remarkup-list-item">Then make the following changes to Dolphin:</li>
</ol>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="diff" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #000080">diff --git a/CMakeLists.txt b/CMakeLists.txt</span>
<span style="color: #000080">index ef0e28e76..a86256950 100644</span>
<span style="color: #a00000">--- a/CMakeLists.txt</span>
<span style="color: #00a000">+++ b/CMakeLists.txt</span>
<span style="color: #800080">@@ -65,6 +65,7 @@ find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS</span>
     Notifications
     Crash
     WindowSystem
<span style="color: #00a000">+    WidgetsAddons</span>
 )
 find_package(KF5 ${KF5_MIN_VERSION} OPTIONAL_COMPONENTS
     Activities
<span style="color: #000080">diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt</span>
<span style="color: #000080">index 8a025e584..80a767aa9 100644</span>
<span style="color: #a00000">--- a/src/CMakeLists.txt</span>
<span style="color: #00a000">+++ b/src/CMakeLists.txt</span>
<span style="color: #800080">@@ -148,6 +148,7 @@ target_link_libraries(</span>
     KF5::ConfigCore
     KF5::NewStuff
     KF5::Parts
<span style="color: #00a000">+    KF5::WidgetsAddons</span>
     KF5::WindowSystem
 )
 
<span style="color: #000080">diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp</span>
<span style="color: #000080">index 1f1c1cea6..80db0bbe9 100644</span>
<span style="color: #a00000">--- a/src/dolphinmainwindow.cpp</span>
<span style="color: #00a000">+++ b/src/dolphinmainwindow.cpp</span>
<span style="color: #800080">@@ -1292,6 +1292,7 @@ void DolphinMainWindow::setupActions()</span>
     }
     m_backAction->setDelayed(true);
     m_backAction->setStickyMenu(false);
<span style="color: #00a000">+    m_backAction->setMenuIndicator(false);</span>
     connect(m_backAction, &QAction::triggered, this, &DolphinMainWindow::goBack);
     connect(m_backAction->menu(), &QMenu::aboutToShow, this, &DolphinMainWindow::slotAboutToShowBackPopupMenu);
     connect(m_backAction->menu(), &QMenu::triggered, this, &DolphinMainWindow::slotGoBack);
<span style="color: #800080">@@ -1327,6 +1328,7 @@ void DolphinMainWindow::setupActions()</span>
     }
     m_forwardAction->setDelayed(true);
     m_forwardAction->setStickyMenu(false);
<span style="color: #00a000">+    m_forwardAction->setMenuIndicator(false);</span>
     connect(m_forwardAction, &QAction::triggered, this, &DolphinMainWindow::goForward);
     connect(m_forwardAction->menu(), &QMenu::aboutToShow, this, &DolphinMainWindow::slotAboutToShowForwardPopupMenu);
     connect(m_forwardAction->menu(), &QMenu::triggered, this, &DolphinMainWindow::slotGoForward);</pre></div>

<p>then build and install Dolphin, and then (phew) you should be able to see that the arrows are gone :D</p>

<p>I have also rebased this patch.</p>

<p>But if we agree to how this feature is implemented, I would suggest that we get this patch merged, then merge the patch for KWidgetAddons, and then when those two has been released, we merge the patch for Dolphin.</p>

<p>What do you think?</p>

<p>Here is a screenshot of how it looks with everything applied:</p>

<p><a href="https://phabricator.kde.org/F6935857" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">F6935857: navigation_history_no_arrows.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20867">https://phabricator.kde.org/D20867</a></div></div><br /><div><strong>To: </strong>hallas, ngraham<br /><strong>Cc: </strong>mart, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>