D19389: Rewrite kworkspace logout, shutdown and suspend API

Kai Uwe Broulik noreply at phabricator.kde.org
Sun Jun 23 10:14:26 BST 2019


broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in sessionmanagement.cpp:95
> I don't see where it did

KDisplayManager::isSwitchable()

checks `CanMultiSession` on the session manager.
and there's also `numReserve()` which seems to be hardcoded to `1` for more modern systems, so that might not be an issue.

> davidedmundson wrote in sessionmanagement.h:93
> We did, but that isn't needed now.
> 
> If you want low level, you can use the SessionManagementBackend to just perform the action directly

Right

> davidedmundson wrote in sessionmanagementbackend.cpp:200
> Honestly, because it's super legacy and I don't really want to spend any time on it. Especially as I need to ask others to test again.
> 
> The old code blocked, anyway

Ah, right consolekit1, fine then.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19389

To: davidedmundson, #plasma
Cc: pino, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190623/be19ccd3/attachment-0001.html>


More information about the Plasma-devel mailing list