D21869: Border for "separator_menu_item" should be 0

[Vlad Zagorodniy]

zzag added a comment.


  I don't like how this patch was reviewed. The underlying problem wasn't fully understood. If an application crashes, then the backtrace is required. I don't see it in the bug report.
  
  >   (seq64:25899): WARNING **: 09:40:24.716: Invalid borders specified for theme pixmap:
  >           /usr/share/themes/Breeze/gtk-2.0/../assets/line-h.png,
  >   borders don't fit within the image
  
  Pixbuf prints that warning because sum of top and bottom border is greater than the height of line-h.png. The most interesting part is that pixbuf tries to adjust borders, i.e.
  
      if (theme_pb->border_left + theme_pb->border_right > width ||
          theme_pb->border_top + theme_pb->border_bottom > height)
        {
          g_warning ("Invalid borders specified for theme pixmap:\n"
    		 "        %s,\n"
    		 "borders don't fit within the image", theme_pb->filename);
          if (theme_pb->border_left + theme_pb->border_right > width)
    	{
    	  theme_pb->border_left = width / 2;
    	  theme_pb->border_right = (width + 1) / 2;
    	}
          if (theme_pb->border_bottom + theme_pb->border_top > height)
    	{
    	  theme_pb->border_top = height / 2;
    	  theme_pb->border_bottom = (height + 1) / 2;
    	}
        }

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D21869

To: vzapod, #breeze, mthw, gepardo, jackg, ngraham
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190619/8f7cca9e/attachment.html>