<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21869">View Revision</a></tr></table><br /><div><div><p>I don't like how this patch was reviewed. The underlying problem wasn't fully understood. If an application crashes, then the backtrace is required. I don't see it in the bug report.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">(seq64:25899): WARNING **: 09:40:24.716: Invalid borders specified for theme pixmap:
        /usr/share/themes/Breeze/gtk-2.0/../assets/line-h.png,
borders don't fit within the image</pre></div></blockquote>

<p>Pixbuf prints that warning because sum of top and bottom border is greater than the height of line-h.png. The most interesting part is that pixbuf tries to adjust borders, i.e.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">  <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_left</span> <span style="color: #aa2211">+</span> <span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_right</span> <span style="color: #aa2211">></span> <span class="n">width</span> <span style="color: #aa2211">||</span>
      <span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_top</span> <span style="color: #aa2211">+</span> <span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_bottom</span> <span style="color: #aa2211">></span> <span class="n">height</span><span class="p">)</span>
    <span class="p">{</span>
      <span class="n">g_warning</span> <span class="p">(</span><span style="color: #766510">"Invalid borders specified for theme pixmap:</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span>
                 <span style="color: #766510">"        %s,</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span>
                 <span style="color: #766510">"borders don't fit within the image"</span><span class="p">,</span> <span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">filename</span><span class="p">);</span>
      <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_left</span> <span style="color: #aa2211">+</span> <span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_right</span> <span style="color: #aa2211">></span> <span class="n">width</span><span class="p">)</span>
        <span class="p">{</span>
          <span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_left</span> <span style="color: #aa2211">=</span> <span class="n">width</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
          <span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_right</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">width</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
        <span class="p">}</span>
      <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_bottom</span> <span style="color: #aa2211">+</span> <span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_top</span> <span style="color: #aa2211">></span> <span class="n">height</span><span class="p">)</span>
        <span class="p">{</span>
          <span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_top</span> <span style="color: #aa2211">=</span> <span class="n">height</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
          <span class="n">theme_pb</span><span style="color: #aa2211">-></span><span class="n">border_bottom</span> <span style="color: #aa2211">=</span> <span class="p">(</span><span class="n">height</span> <span style="color: #aa2211">+</span> <span style="color: #601200">1</span><span class="p">)</span> <span style="color: #aa2211">/</span> <span style="color: #601200">2</span><span class="p">;</span>
        <span class="p">}</span>
    <span class="p">}</span></pre></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R98 Breeze for Gtk</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21869">https://phabricator.kde.org/D21869</a></div></div><br /><div><strong>To: </strong>vzapod, Breeze, mthw, gepardo, jackg, ngraham<br /><strong>Cc: </strong>ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>