D21884: [Touchpad KCM] Do not crash in case there is no touchpad
Bastian Beischer
noreply at phabricator.kde.org
Tue Jun 18 21:03:31 BST 2019
beischer added a comment.
In D21884#481568 <https://phabricator.kde.org/D21884#481568>, @romangg wrote:
> Ok, that would be even better. Only drawback is then that it shows the "wrong" interface in case libinput is used until a touchpad is plugged, but that's such an uncommon case that I don't think we should invest much more time into it. On the other side since libinput is the default backend in the future it might make more sense to show the libinput one per default if no touchpad is plugged in. Would this also be possible or is the current X libinput backend missing this funcitonality? At least from user perspective it could be confusing to see the non-default backend on the workstation without touchpad and something completely different on his laptop.
I think one could set m_plugin to "TouchpadConfigLibinput(this, backend)" (as would be the case with a libinput touchpad). I just tried that, this produces the following result:
F6908042: no_touchpad_libinput.png <https://phabricator.kde.org/F6908042>
That doesn't look right to me? Maybe because TouchpadConfigContainer::kcmInit() is a no-op (first because the mode is Unset, so neither of the two if branches triggers, but even if that is fixed it's a noop because m_device is null in the xlibbackend).
REPOSITORY
R119 Plasma Desktop
BRANCH
bug-408325 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21884
To: beischer, ngraham, romangg, atulbi, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190618/773f2aa6/attachment-0001.html>
More information about the Plasma-devel
mailing list