D21725: Use a native application for starting plasma

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in startplasma.cpp:34
> old code killed ksplash when we showed a message

Now we will return, which will get KSplash out of scope and kill the process upon destruction. See KillBeforeDeleter.

> davidedmundson wrote in startplasma.cpp:123
> Not a blocker, but why not use KConfig here?

Because this is clearly faster and not complex at all to read. I can change it if you like.
This way we don't worry about reading global files and such.

> davidedmundson wrote in startplasma.cpp:284
> This is wrong.
> 
> forceFontDPI is a number
> we need to read that from the config file and send that to xrdb.
> 
> you can verify it works with
> 
> xrdb -q | grep Xft
> 
> in your session afterwards

Good catch.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21725

To: apol, #plasma, fvogt
Cc: broulik, fvogt, davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190613/30b907dc/attachment.html>