D21725: Use a native application for starting plasma

[David Edmundson]

davidedmundson added a comment.


  Two minor things and then this is good to go.

INLINE COMMENTS

> startplasma.cpp:34
> +
> +void messageBox(const QString &text)
> +{

old code killed ksplash when we showed a message

> startplasma.cpp:123
> +    const QString localerc(configDir + QLatin1String("/plasma-localerc"));
> +    if (!QFile::exists(localerc)) {
> +        QFile f(localerc);

Not a blocker, but why not use KConfig here?

> startplasma.cpp:284
> +    //TODO port to c++?
> +    const QByteArray input = "Xft.dpi: kcmfonts_general_forcefontdpi";
> +    QProcess p;

This is wrong.

forceFontDPI is a number
we need to read that from the config file and send that to xrdb.

you can verify it works with

xrdb -q | grep Xft

in your session afterwards

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21725

To: apol, #plasma, fvogt
Cc: broulik, fvogt, davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190613/1c720fd7/attachment.html>