D21647: send signal to breeze to trigger reparsing the color scheme

[Sebastian Kügler]

sebas created this revision.
sebas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sebas requested review of this revision.

REVISION SUMMARY
  Without this patch, changing the application color scheme from system
  settings only affects some widgets. Notably, checkboxes highlighting
  colors stays the old color, leading to a hodge-podge color scheme and
  bad contrast on some items.
  
  The breeze QStyle caches the colors read via KSharedConfig, so it needs
  to re-read the configuration when the application color changes. Breeze
  has a dbus listener on the signal we emit in this patch and will act
  accordingly. Currently, no one sends this signal.
  
  Another way to achieve this is to installl an eventfilter on qApp in the
  breeze style, see https://phabricator.kde.org/D21646
  
  This fixes the coloring of various widgets in breeze right after color
  changes.
  
  Patch will probably need manual forward-porting to master since the KCM
  has been rewritten using QtQuick. I can do that, but someone would need
  to test.
  
  BUG:408416
  FIXED-IN: 5.15.6
  
  Those I haven't tested, but look quite suspicious (so please re-test):
  CCBUG:382505
  CCBUG:355295

TEST PLAN
  open kcmshell5 colors
  change to a theme with a different highlight color
  apply
  without patch: checkbox in color KCM (and a whole lot of other widgets all over the place) don't change colors
  with patch: colors change as expected

REPOSITORY
  R119 Plasma Desktop

BRANCH
  colorchange-stable

REVISION DETAIL
  https://phabricator.kde.org/D21647

AFFECTED FILES
  kcms/colors/colorscm.cpp

To: sebas, #plasma
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190607/cadb92b8/attachment-0001.html>