<table><tr><td style="">sebas created this revision.<br />sebas added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />sebas requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21647">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Without this patch, changing the application color scheme from system<br />
settings only affects some widgets. Notably, checkboxes highlighting<br />
colors stays the old color, leading to a hodge-podge color scheme and<br />
bad contrast on some items.</p>
<p>The breeze QStyle caches the colors read via KSharedConfig, so it needs<br />
to re-read the configuration when the application color changes. Breeze<br />
has a dbus listener on the signal we emit in this patch and will act<br />
accordingly. Currently, no one sends this signal.</p>
<p>Another way to achieve this is to installl an eventfilter on qApp in the<br />
breeze style, see <a href="https://phabricator.kde.org/D21646" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/D21646</a></p>
<p>This fixes the coloring of various widgets in breeze right after color<br />
changes.</p>
<p>Patch will probably need manual forward-porting to master since the KCM<br />
has been rewritten using QtQuick. I can do that, but someone would need<br />
to test.</p>
<p>BUG:408416<br />
FIXED-IN: 5.15.6</p>
<p>Those I haven't tested, but look quite suspicious (so please re-test):<br />
CCBUG:382505<br />
CCBUG:355295</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>open kcmshell5 colors<br />
change to a theme with a different highlight color<br />
apply<br />
without patch: checkbox in color KCM (and a whole lot of other widgets all over the place) don't change colors<br />
with patch: colors change as expected</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>colorchange-stable</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21647">https://phabricator.kde.org/D21647</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcms/colors/colorscm.cpp</div></div></div><br /><div><strong>To: </strong>sebas, Plasma<br /><strong>Cc: </strong>plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>