D21620: Handle Esc properly when focus is in searchbox
Nathaniel Graham
noreply at phabricator.kde.org
Thu Jun 6 16:08:09 BST 2019
ngraham added a comment.
@jgrulich unless you object, I'll land this on the stable branch once my comment has been addressed.
INLINE COMMENTS
> Toolbar.qml:154
> onVisibleChanged: if (!visible) text = ""
> - Keys.onEscapePressed: searchToggleButton.checked = false
> + Keys.onEscapePressed: {
> + if (searchToggleButton.checked) {
Could you add a comment explaining why this is necessary?
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D21620
To: kishoreg, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190606/dae0d616/attachment.html>
More information about the Plasma-devel
mailing list