D21620: Handle Esc properly when focus is in searchbox

Kishore Gopalakrishnan noreply at phabricator.kde.org
Thu Jun 6 15:43:59 BST 2019


kishoreg created this revision.
kishoreg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
kishoreg requested review of this revision.

REVISION SUMMARY
  BUG: 408290
  
  If we place the focus in the searchbar, pressing Esc once dismisses the searchbar. However, pressing Esc after this does not dismiss the popup unless one manually intereacts with some other element in the popup. This patch fixes the issue.

TEST PLAN
  1. Open the Networks popup in the systray.
  2. Click the search icon above the channels list.
  3. Click in the search area to place focus there.
  4. Press Esc. Searchbar disappears.
  5. Press Esc again. Check that the popup closes.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D21620

AFFECTED FILES
  applet/contents/ui/Toolbar.qml

To: kishoreg, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190606/90bb6817/attachment-0001.html>


More information about the Plasma-devel mailing list