D22845: [GTK3] Convert all colors to use GTK color definitions
Carson Black
noreply at phabricator.kde.org
Wed Jul 31 01:32:09 BST 2019
cblack created this revision.
cblack added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.
REVISION SUMMARY
All of the colors pulled from a colorscheme in Breeze GTK now use GTK's color definitons, allowing them to be changed without recompiling the theme.
GTK18 and GTK20 have been merged as well, lessening work required to make changes & maintain.
There are some other minor changes (radio buttons/checkboxes now sink in when clicking as their Qt counterparts do.)
The varaible $new-highlight has been added to gtk.scss. Toggling it to true will cause the highlights to resemble ndavis/highlight @ Breeze. Added that because I had already made the changes to the theme when I did the colordefs, and I don't want to wait on the new highlight style to be set in stone before this can be merged.
TEST PLAN
See that the theme works as intended with GTK color definitions.
REPOSITORY
R98 Breeze for Gtk
BRANCH
colordefs (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D22845
AFFECTED FILES
src/_colors.scss
src/_functions.scss
src/build_theme.sh
src/gtk-dark-3.18.css
src/gtk-dark-3.20.css
src/gtk-dark.css
src/gtk3/gtk.scss
src/gtk3/widgets/_app_notifications.scss
src/gtk3/widgets/_base.scss
src/gtk3/widgets/_button.scss
src/gtk3/widgets/_calendar.scss
src/gtk3/widgets/_checkboxes.scss
src/gtk3/widgets/_color_chooser.scss
src/gtk3/widgets/_dialogs.scss
src/gtk3/widgets/_entry.scss
src/gtk3/widgets/_headerbar.scss
src/gtk3/widgets/_infobar.scss
src/gtk3/widgets/_link.scss
src/gtk3/widgets/_lists.scss
src/gtk3/widgets/_menus.scss
src/gtk3/widgets/_misc.scss
src/gtk3/widgets/_notebook.scss
src/gtk3/widgets/_overshoot.scss
src/gtk3/widgets/_pathbar.scss
src/gtk3/widgets/_progressbar.scss
src/gtk3/widgets/_scale.scss
src/gtk3/widgets/_scrollbar.scss
src/gtk3/widgets/_sidebar.scss
src/gtk3/widgets/_spinbutton.scss
src/gtk3/widgets/_switch.scss
src/gtk3/widgets/_toolbar.scss
src/gtk3/widgets/_tooltips.scss
src/gtk3/widgets/_treeview.scss
src/gtk3/widgets/_window_decorations.scss
src/gtk318/gtk.scss
src/gtk318/widgets/_app_notifications.scss
src/gtk318/widgets/_base.scss
src/gtk318/widgets/_button.scss
src/gtk318/widgets/_calendar.scss
src/gtk318/widgets/_checkboxes.scss
src/gtk318/widgets/_color_chooser.scss
src/gtk318/widgets/_dialogs.scss
src/gtk318/widgets/_entry.scss
src/gtk318/widgets/_headerbar.scss
src/gtk318/widgets/_infobar.scss
src/gtk318/widgets/_link.scss
src/gtk318/widgets/_lists.scss
src/gtk318/widgets/_menus.scss
src/gtk318/widgets/_misc.scss
src/gtk318/widgets/_notebook.scss
src/gtk318/widgets/_overshoot.scss
src/gtk318/widgets/_pathbar.scss
src/gtk318/widgets/_progressbar.scss
src/gtk318/widgets/_scale.scss
src/gtk318/widgets/_scrollbar.scss
src/gtk318/widgets/_sidebar.scss
src/gtk318/widgets/_spinbutton.scss
src/gtk318/widgets/_switch.scss
src/gtk318/widgets/_toolbar.scss
src/gtk318/widgets/_tooltips.scss
src/gtk318/widgets/_treeview.scss
src/gtk318/widgets/_window_decorations.scss
src/gtk320/gtk.scss
src/gtk320/widgets/_app_notifications.scss
src/gtk320/widgets/_base.scss
src/gtk320/widgets/_button.scss
src/gtk320/widgets/_calendar.scss
src/gtk320/widgets/_checkboxes.scss
src/gtk320/widgets/_color_chooser.scss
src/gtk320/widgets/_dialogs.scss
src/gtk320/widgets/_entry.scss
src/gtk320/widgets/_headerbar.scss
src/gtk320/widgets/_infobar.scss
src/gtk320/widgets/_link.scss
src/gtk320/widgets/_lists.scss
src/gtk320/widgets/_menus.scss
src/gtk320/widgets/_misc.scss
src/gtk320/widgets/_notebook.scss
src/gtk320/widgets/_overshoot.scss
src/gtk320/widgets/_pathbar.scss
src/gtk320/widgets/_progressbar.scss
src/gtk320/widgets/_scale.scss
src/gtk320/widgets/_scrollbar.scss
src/gtk320/widgets/_sidebar.scss
src/gtk320/widgets/_spinbutton.scss
src/gtk320/widgets/_switch.scss
src/gtk320/widgets/_toolbar.scss
src/gtk320/widgets/_tooltips.scss
src/gtk320/widgets/_treeview.scss
src/gtk320/widgets/_window_decorations.scss
To: cblack, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190731/3d82a723/attachment.html>
More information about the Plasma-devel
mailing list