<table><tr><td style="">cblack created this revision.<br />cblack added reviewers: VDG, Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />cblack requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22845">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>All of the colors pulled from a colorscheme in Breeze GTK now use GTK's color definitons, allowing them to be changed without recompiling the theme.<br />
GTK18 and GTK20 have been merged as well, lessening work required to make changes & maintain.<br />
There are some other minor changes (radio buttons/checkboxes now sink in when clicking as their Qt counterparts do.)<br />
The varaible $new-highlight has been added to gtk.scss. Toggling it to true will cause the highlights to resemble ndavis/highlight @ Breeze. Added that because I had already made the changes to the theme when I did the colordefs, and I don't want to wait on the new highlight style to be set in stone before this can be merged.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>See that the theme works as intended with GTK color definitions.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R98 Breeze for Gtk</div></div></div><br /><div><strong>BRANCH</strong><div><div>colordefs (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22845">https://phabricator.kde.org/D22845</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/_colors.scss<br />
src/_functions.scss<br />
src/build_theme.sh<br />
src/gtk-dark-3.18.css<br />
src/gtk-dark-3.20.css<br />
src/gtk-dark.css<br />
src/gtk3/gtk.scss<br />
src/gtk3/widgets/_app_notifications.scss<br />
src/gtk3/widgets/_base.scss<br />
src/gtk3/widgets/_button.scss<br />
src/gtk3/widgets/_calendar.scss<br />
src/gtk3/widgets/_checkboxes.scss<br />
src/gtk3/widgets/_color_chooser.scss<br />
src/gtk3/widgets/_dialogs.scss<br />
src/gtk3/widgets/_entry.scss<br />
src/gtk3/widgets/_headerbar.scss<br />
src/gtk3/widgets/_infobar.scss<br />
src/gtk3/widgets/_link.scss<br />
src/gtk3/widgets/_lists.scss<br />
src/gtk3/widgets/_menus.scss<br />
src/gtk3/widgets/_misc.scss<br />
src/gtk3/widgets/_notebook.scss<br />
src/gtk3/widgets/_overshoot.scss<br />
src/gtk3/widgets/_pathbar.scss<br />
src/gtk3/widgets/_progressbar.scss<br />
src/gtk3/widgets/_scale.scss<br />
src/gtk3/widgets/_scrollbar.scss<br />
src/gtk3/widgets/_sidebar.scss<br />
src/gtk3/widgets/_spinbutton.scss<br />
src/gtk3/widgets/_switch.scss<br />
src/gtk3/widgets/_toolbar.scss<br />
src/gtk3/widgets/_tooltips.scss<br />
src/gtk3/widgets/_treeview.scss<br />
src/gtk3/widgets/_window_decorations.scss<br />
src/gtk318/gtk.scss<br />
src/gtk318/widgets/_app_notifications.scss<br />
src/gtk318/widgets/_base.scss<br />
src/gtk318/widgets/_button.scss<br />
src/gtk318/widgets/_calendar.scss<br />
src/gtk318/widgets/_checkboxes.scss<br />
src/gtk318/widgets/_color_chooser.scss<br />
src/gtk318/widgets/_dialogs.scss<br />
src/gtk318/widgets/_entry.scss<br />
src/gtk318/widgets/_headerbar.scss<br />
src/gtk318/widgets/_infobar.scss<br />
src/gtk318/widgets/_link.scss<br />
src/gtk318/widgets/_lists.scss<br />
src/gtk318/widgets/_menus.scss<br />
src/gtk318/widgets/_misc.scss<br />
src/gtk318/widgets/_notebook.scss<br />
src/gtk318/widgets/_overshoot.scss<br />
src/gtk318/widgets/_pathbar.scss<br />
src/gtk318/widgets/_progressbar.scss<br />
src/gtk318/widgets/_scale.scss<br />
src/gtk318/widgets/_scrollbar.scss<br />
src/gtk318/widgets/_sidebar.scss<br />
src/gtk318/widgets/_spinbutton.scss<br />
src/gtk318/widgets/_switch.scss<br />
src/gtk318/widgets/_toolbar.scss<br />
src/gtk318/widgets/_tooltips.scss<br />
src/gtk318/widgets/_treeview.scss<br />
src/gtk318/widgets/_window_decorations.scss<br />
src/gtk320/gtk.scss<br />
src/gtk320/widgets/_app_notifications.scss<br />
src/gtk320/widgets/_base.scss<br />
src/gtk320/widgets/_button.scss<br />
src/gtk320/widgets/_calendar.scss<br />
src/gtk320/widgets/_checkboxes.scss<br />
src/gtk320/widgets/_color_chooser.scss<br />
src/gtk320/widgets/_dialogs.scss<br />
src/gtk320/widgets/_entry.scss<br />
src/gtk320/widgets/_headerbar.scss<br />
src/gtk320/widgets/_infobar.scss<br />
src/gtk320/widgets/_link.scss<br />
src/gtk320/widgets/_lists.scss<br />
src/gtk320/widgets/_menus.scss<br />
src/gtk320/widgets/_misc.scss<br />
src/gtk320/widgets/_notebook.scss<br />
src/gtk320/widgets/_overshoot.scss<br />
src/gtk320/widgets/_pathbar.scss<br />
src/gtk320/widgets/_progressbar.scss<br />
src/gtk320/widgets/_scale.scss<br />
src/gtk320/widgets/_scrollbar.scss<br />
src/gtk320/widgets/_sidebar.scss<br />
src/gtk320/widgets/_spinbutton.scss<br />
src/gtk320/widgets/_switch.scss<br />
src/gtk320/widgets/_toolbar.scss<br />
src/gtk320/widgets/_tooltips.scss<br />
src/gtk320/widgets/_treeview.scss<br />
src/gtk320/widgets/_window_decorations.scss</div></div></div><br /><div><strong>To: </strong>cblack, VDG, Plasma<br /><strong>Cc: </strong>plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>