D22767: Calculate first clickable point, from the top-left

David Edmundson noreply at phabricator.kde.org
Mon Jul 29 11:53:51 BST 2019


davidedmundson added inline comments.

INLINE COMMENTS

> sniproxy.cpp:576
>          event->root = QX11Info::appRootWindow();
>          event->root_x = x;
>          event->root_y = y;

This point was marked as closed, but not changed.  Probably my fault for not expanding.

We move the window so that it's at x-clickPoint
The relative point is clickPoint.x

The absolute position of the click should be offset by the same amount. I would have expected

> event->root_x = x + clickPoint.x
> event->root_y = y + clickPoint.y

in both places

REVISION DETAIL
  https://phabricator.kde.org/D22767

To: kmaterka, #plasma_workspaces
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190729/e686797a/attachment.html>


More information about the Plasma-devel mailing list