D22738: Remove some uses on QDesktopWidget

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  concept ++

INLINE COMMENTS

> pagermodel.cpp:120
> +    QObject::connect(qGuiApp, &QGuiApplication::screenAdded, q, [q](QScreen* screen) {
> +        QObject::connect(screen, &QScreen::geometryChanged, q, &PagerModel::pagerItemSizeChanged);
> +        q->pagerItemSizeChanged();

we need this connection for screens that already exist when this code runs

> foldermodel.cpp:1640
>  
> -    m_newMenu = new KNewFileMenu(&m_actionCollection, QStringLiteral("newMenu"), QApplication::desktop());
> +    m_newMenu = new KNewFileMenu(&m_actionCollection, QStringLiteral("newMenu"), this);
>      m_newMenu->setModal(false);

KNewFileMenu.cpp in the constructor
 1148     d->m_parentWidget = qobject_cast<QWidget *>(parent);

without a transient parent we probably have focus issues?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22738

To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190725/2b7497f8/attachment-0001.html>