<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22738">View Revision</a></tr></table><br /><div><div><p>concept ++</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22738#inline-128418">View Inline</a><span style="color: #4b4d51; font-weight: bold;">pagermodel.cpp:120</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QObject</span><span style="color: #aa2211">::</span><span class="n">connect</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">desktopWidget</span></span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">Q<span class="bright">DesktopWidget</span></span><span style="color: #aa2211">::</span><span class="n">screen<span class="bright">CountChanged</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="n">q</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">PagerModel</span><span style="color: #aa2211">::</span><span class="n">pagerItemSizeChanged</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="bright"></span><span class="n"><span class="bright">QObject</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">connect</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">desktopWidget</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">QDesktopWidget</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">resized</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QObject</span><span style="color: #aa2211">::</span><span class="n">connect</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">qGuiApp</span></span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">Q<span class="bright">GuiApplication</span></span><span style="color: #aa2211">::</span><span class="n">screen<span class="bright">Added</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">q</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="p"><span class="bright">[</span></span><span class="bright"></span><span class="n"><span class="bright">q</span></span><span class="bright"></span><span class="p"><span class="bright">](</span></span><span class="bright"></span><span class="n"><span class="bright">QScreen</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">screen</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span class="n"><span class="bright">QObject</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">connect</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">screen</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&</span></span><span class="bright"></span><span class="n"><span class="bright">QScreen</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">geometryChanged</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n">q</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">PagerModel</span><span style="color: #aa2211">::</span><span class="n">pagerItemSizeChanged</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright">    </span><span class="n"><span class="bright">q</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">pagerItemSizeChanged</span></span><span class="bright"></span><span class="p"><span class="bright">();</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we need this connection for screens that already exist when this code runs</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22738#inline-128419">View Inline</a><span style="color: #4b4d51; font-weight: bold;">foldermodel.cpp:1640</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">m_newMenu</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KNewFileMenu</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">m_actionCollection</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"newMenu"</span><span class="p">),</span> <span class="bright"></span><span class="n"><span class="bright">QApplication</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">desktop</span></span><span class="bright"></span><span class="p"><span class="bright">()</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">m_newMenu</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">KNewFileMenu</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">m_actionCollection</span><span class="p">,</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"newMenu"</span><span class="p">),</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">this</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">m_newMenu</span><span style="color: #aa2211">-></span><span class="n">setModal</span><span class="p">(</span><span style="color: #304a96">false</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">KNewFileMenu.cpp in the constructor<br />
 1148     d->m_parentWidget = qobject_cast<QWidget *>(parent);</p>

<p style="padding: 0; margin: 8px;">without a transient parent we probably have focus issues?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22738">https://phabricator.kde.org/D22738</a></div></div><br /><div><strong>To: </strong>apol, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>