D22564: [RFC] [SwipeListItem] Take into account scrollbar visibility and form factor

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sat Jul 20 10:25:33 BST 2019


apol added inline comments.

INLINE COMMENTS

> SwipeListItem.qml:241
>                  verticalCenter: parent.verticalCenter
> -                rightMargin: Units.gridUnit
> +                rightMargin: !Settings.isMobile && behindItem.view && behindItem.view.T2.ScrollBar && behindItem.view.T2.ScrollBar.vertical && behindItem.view.T2.ScrollBar.vertical.visible ? behindItem.view.T2.ScrollBar.vertical.width : Units.smallSpacing
>              }

Wouldn't checking for scrollbar visibility be enough? if there's a scrollbar but isMobile we still want the different spacing.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22564

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190720/49dec879/attachment.html>


More information about the Plasma-devel mailing list