D22363: Remove cursor theme option

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:119
> +    ActionReply reply = ActionReply::HelperErrorReply();
> +    QSharedPointer<KConfig> sddmConfig = openConfig(args[QStringLiteral("kde_settings.conf")].toString());
> +    QSharedPointer<KConfig> sddmOldConfig = openConfig(args[QStringLiteral("sddm.conf")].toString());

Task for another day, we don't need to pass this in every time.

We can set this at compile time, using the same values from config.h as the KCM would use

> advanceconfig.cpp:205
> +    args[QStringLiteral("sddmUserConfig")] = sddmUserConfigPath;
> +    args[QStringLiteral("kde_settings.conf/Theme/CursorTheme")] = QStringLiteral("nothing");
>  

why?

> advanceconfig.ui:220
> +          <iconset theme="edit-undo">
> +           <normaloff>.</normaloff>.</iconset>
>           </property>

that seems odd?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22363

To: filipf, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190719/3c207e32/attachment-0001.html>