<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22363">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22363#inline-127465">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sddmauthhelper.cpp:119</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">ActionReply</span> <span class="n">reply</span> <span style="color: #aa2211">=</span> <span class="n">ActionReply</span><span style="color: #aa2211">::</span><span class="n">HelperErrorReply</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QSharedPointer</span><span style="color: #aa2211"><</span><span class="n">KConfig</span><span style="color: #aa2211">></span> <span class="n">sddmConfig</span> <span style="color: #aa2211">=</span> <span class="n">openConfig</span><span class="p">(</span><span class="n">args</span><span class="p">[</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kde_settings.conf"</span><span class="p">)].</span><span class="n">toString</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QSharedPointer</span><span style="color: #aa2211"><</span><span class="n">KConfig</span><span style="color: #aa2211">></span> <span class="n">sddmOldConfig</span> <span style="color: #aa2211">=</span> <span class="n">openConfig</span><span class="p">(</span><span class="n">args</span><span class="p">[</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"sddm.conf"</span><span class="p">)].</span><span class="n">toString</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Task for another day, we don't need to pass this in every time.</p>

<p style="padding: 0; margin: 8px;">We can set this at compile time, using the same values from config.h as the KCM would use</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22363#inline-127463">View Inline</a><span style="color: #4b4d51; font-weight: bold;">advanceconfig.cpp:205</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">args</span><span class="p">[</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"sddmUserConfig"</span><span class="p">)]</span> <span style="color: #aa2211">=</span> <span class="n">sddmUserConfigPath</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">args</span><span class="p">[</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kde_settings.conf/Theme/CursorTheme"</span><span class="p">)]</span> <span style="color: #aa2211">=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"nothing"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22363#inline-127464">View Inline</a><span style="color: #4b4d51; font-weight: bold;">advanceconfig.ui:220</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">          <iconset theme="edit-undo"<span class="bright">/</span>>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">          <iconset theme="edit-undo">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">           <normaloff>.</normaloff>.</iconset>
</div><div style="padding: 0 8px; margin: 0 4px; ">         </property>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">that seems odd?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R123 SDDM Configuration Panel (KCM)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22363">https://phabricator.kde.org/D22363</a></div></div><br /><div><strong>To: </strong>filipf, ngraham, davidedmundson<br /><strong>Cc: </strong>plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>