D22539: Fix broken guard that prevents styling sliders with negative values
David Edmundson
noreply at phabricator.kde.org
Thu Jul 18 20:47:56 BST 2019
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Setting the minimum to at least 0 was added to fix a crash, however it
seems the root problem was a crash if maximum was < minimum not whether
they were negative or not.
TEST PLAN
Used via QQC2
Set min and max to negative
Still worked as expected
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22539
AFFECTED FILES
plugin/kquickstyleitem.cpp
To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190718/9bdba352/attachment.html>
More information about the Plasma-devel
mailing list