D22034: Introduce ContainmentLayoutManager QML plugin

David Edmundson noreply at phabricator.kde.org
Thu Jul 18 15:22:55 BST 2019


davidedmundson added inline comments.

INLINE COMMENTS

> configoverlay.h:67
> +private:
> +    void setItemContainer(ItemContainer *container);
> +

Given ItemContainer instantiates this object (or a subclass therefore) can we make this public and call it from ItemContainer::setConfigOverlayVisible

Then we get rid of one of the two searches through parents.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22034

To: mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190718/d2696004/attachment.html>


More information about the Plasma-devel mailing list