D22034: Introduce ContainmentLayoutManager QML plugin

Marco Martin noreply at phabricator.kde.org
Thu Jul 18 14:09:23 BST 2019


mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in itemcontainer.cpp:438
> If we want to use this in the panel/wherever we need ItemContainer to forward the full min/preferred/max sizes (with margins added) and have the LayoutManager be the one that takes this information and resizes the container.
> 
> IMHO it shouldn't resize itself, it should just emit sizeHintChanged
> 
> Then in AbstractLayoutManager we have a connect that does the current:
> 
> releaseSpace(item)
> resizeFromSizeHints(item)
> positionItem(item)
> 
> It then gives full absolute control to the manager, rather than it doing part and then the item doing part.

same code now moved in the layoutmanager

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22034

To: mart, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190718/0796dd8e/attachment-0001.html>


More information about the Plasma-devel mailing list