D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

Michail Vourlakos noreply at phabricator.kde.org
Mon Jul 15 10:41:09 BST 2019


mvourlakos added a subscriber: ngraham.
mvourlakos added a comment.


  In D22468#495723 <https://phabricator.kde.org/D22468#495723>, @romangg wrote:
  
  > In D22468#495719 <https://phabricator.kde.org/D22468#495719>, @mvourlakos wrote:
  >
  > > This looks really nice,
  > >
  > > one question, having current values under the Slider does it follow a HIG rule or is it a proposition?
  >
  >
  > I copied this style from Night Color KCM. I didn't consult the HIG on that and to be honest I don't really like the look of it. Lone numbers feels unconnected to the slider and margins are kind of messed up. Imo slider components should provide an interface to add current value labels to them in a convenient and standardized fashion. Maybe as a Kirigami component?
  
  
  I agree it looks weird, especially because it breaks visual vertical alignment with the label on the left.
  
  @ngraham is there any HIG proposition how current values of sliders should be positioned?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D22468

To: romangg, #plasma, #kwin
Cc: ngraham, mvourlakos, knambiar, broulik, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190715/4a5d400e/attachment.html>


More information about the Plasma-devel mailing list