D22403: qobject_cast rather than dynamic_cast

Harald Sitter noreply at phabricator.kde.org
Thu Jul 11 15:59:35 BST 2019


sitter added inline comments.

INLINE COMMENTS

> broulik wrote in reportassistantdialog.cpp:285
> Why does it check for `page` here but not down below? (Unrelated question to this patch)

the entire class is a hot mess WRT pointer management I think

REPOSITORY
  R871 DrKonqi

BRANCH
  qobjectcast

REVISION DETAIL
  https://phabricator.kde.org/D22403

To: sitter, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190711/9668fdb2/attachment.html>


More information about the Plasma-devel mailing list