D22403: qobject_cast rather than dynamic_cast

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> reportassistantdialog.cpp:285
> +    ReportAssistantPage *page = qobject_cast<ReportAssistantPage *>(currentPage()->widget());
> +    if (page && !page->showNextPage()) {
> +        return;

Why does it check for `page` here but not down below? (Unrelated question to this patch)

REPOSITORY
  R871 DrKonqi

BRANCH
  qobjectcast

REVISION DETAIL
  https://phabricator.kde.org/D22403

To: sitter, #plasma, broulik
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190711/8e4f8d1a/attachment.html>