D22402: only benchmark once

Harald Sitter noreply at phabricator.kde.org
Thu Jul 11 15:34:30 BST 2019


sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  benchmarking N times slows down the test considerably for what feels like
  zero testing advantage. getting just some rough benchmark data should
  be entirely sufficient for a unit test. when more detailed
  benchmarking is required one can easily switch the benchmark macro

TEST PLAN
  6 times faster test pass

REPOSITORY
  R871 DrKonqi

BRANCH
  faster-test

REVISION DETAIL
  https://phabricator.kde.org/D22402

AFFECTED FILES
  src/tests/backtraceparsertest/backtraceparsertest.cpp

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190711/d822c313/attachment.html>


More information about the Plasma-devel mailing list