D22344: Expose some more settings in an Advanced dialog

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ipv4widget.cpp:424
> +{
> +    QPointer<QDialog> dlg = new QDialog(this);
> +

What's that `QPointer` for?
You might want to `dlg->setAttribute(Qt::WA_DeleteOnClose);`

> ipv4widget.cpp:427
> +    auto layout = new QFormLayout(dlg);
> +    dlg->setLayout(layout);
> +

I would prefer that you used a UI file for all of this

> ipv4widget.cpp:455
> +
> +    dlg->setModal(true);
> +    dlg->show();

Doesn't seem to work? Or did you disable the dimming effect or is that a quirk in conjunction with `QQuickWidget` in systemsettings?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22344

To: apol, #plasma, jgrulich
Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190709/128be95d/attachment.html>