D22344: Expose some more settings in an Advanced dialog

Nathaniel Graham noreply at phabricator.kde.org
Tue Jul 9 18:58:43 BST 2019


ngraham added inline comments.

INLINE COMMENTS

> ipv4widget.cpp:431
> +    sendHostname->setChecked(m_tmpIpv4Setting.dhcpSendHostname());
> +    layout->addRow(i18n("Send Hostname"), sendHostname);
> +

Add a colon and don't use Title Case: "Send hostname:"

> ipv4widget.cpp:435
> +    dhcpHostname->setText(m_tmpIpv4Setting.dhcpHostname());
> +    layout->addRow(i18n("DHCP Hostname"), dhcpHostname);
> +

Add a colon and don't use Title Case: "DHCP hostname:"

> ipv4widget.cpp:440
> +    dadTimeout->setValue(m_tmpIpv4Setting.dadTimeout());
> +    layout->addRow(i18n("DAD Timeout"), dadTimeout);
> +

Add a colon and don't use Title Case: "DAD timeout:"

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22344

To: apol, #plasma, jgrulich
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190709/cd860a70/attachment-0001.html>


More information about the Plasma-devel mailing list