D18579: Rework Sensor Browser

[Tomaz Canabrava]

tcanabrava added inline comments.

INLINE COMMENTS

> argonel wrote in SensorBrowser.cpp:51
> This one caused me to notice the style issues. The rule is "For pointers or references, use a single space before '*' or '&', but not after"

ups. that was a typo.

> argonel wrote in SensorBrowser.cpp:624
> The removal of this constructor eliminates this assert. You've kept the others, perhaps move it to SensorBrowserModel::makeSensor?

I could argue that's impossible to hit this assert and that's preciosism (just like a try { } catch (...) after every 'new') but I can do that.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D18579

To: tcanabrava
Cc: argonel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190130/5a92516f/attachment-0001.html>