D18579: Rework Sensor Browser

[Eli MacKenzie]

argonel added inline comments.

INLINE COMMENTS

> SensorBrowser.cpp:51
> +    const int id;
> +    KSGRD::SensorAgent * sensorAgent;
> +    const QString hostName;

This one caused me to notice the style issues. The rule is "For pointers or references, use a single space before '*' or '&', but not after"

> SensorBrowser.cpp:624
> -{
> -    Q_ASSERT(mHostInfo);
> -}

The removal of this constructor eliminates this assert. You've kept the others, perhaps move it to SensorBrowserModel::makeSensor?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D18579

To: tcanabrava
Cc: argonel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190129/657f2865/attachment.html>