D18598: Defer initial positions apply until listing is complete

[David Edmundson]

davidedmundson added a comment.


  If the QML code calls setPositions({})  and when we apply m_positions.size() < 5
  m_deferApplyPositions gets left on true forever.  Is that ok?
  
  Other than that, looks good.

INLINE COMMENTS

> positioner.cpp:82
>          if (m_folderModel) {
>              disconnectSignals(m_folderModel);
>          }

you're not disconnecting newly added connections

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18598

To: hein, #plasma, davidedmundson, chinmoyr
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190129/c94cbbb6/attachment.html>